Support for Unknown Fields (Rebase of #574) #1340
Conversation
Does not compile, incomplete.
- Rename UnknownFieldSet to UnknownFieldList, as requested by maintainer
caspermeijn
- Change fixed32 and fixed64 representation to be consistent with C++
implementation, as requested by caspermeijn
- start resolving build-time errors
- Currently failing with reexported crate issues
- TODO: What endianness is protobuf?
This section should be added back (and/or modified to fit new standards), but commenting out for now to reduce points of failure to resolve creating bad Copy derives
Instead of checking against empty, which can fail differently. Attempting to force fields with unknown to not have a derived Copy.
While this is a change made by rustfmt/clippy, it's outside the scope of this PR, so it's been removed
Seems like local clippy check runs in rust edition 2021, CI runs in 2024
blizzardfinnegan
changed the title
|
@caspermeijn Unfortunately, Github doesn't have a clear way to request reviews on a PR for someone outside the org and/or not a direct developer on the project, otherwise I would have done so. Apologies for the ping if that isn't the right channel. |
|
@blizzardfinnegan AFAIK you could remove or comment out the ignored tests here in order to verify the implementation: https://github.com/blizzardfinnegan/prost/blob/feature/unknown_fields_support/conformance/failing_tests.txt |
|
@alebar42 Thank you for the correction and clarification! Either way, the tests do in fact pass Edit: Unclear what was the issue, but said changes are now in the PR, which is the important part. |
2 participants
For more information see Issue #2
This PR is largely similar to #574 , rebased to main, and with edits suggested by the maintainer on said PR implemented to the best of my ability.