Skip to content

Conversation

BugenZhao
Copy link

Motivation

Hi, all. As proposed in #2784, this PR records the error sources in fmt layer with JSON format, for both spans and events.

Solution

  • Override record_error of fmt::JsonVisitor for span fields.
  • Override record_error of serde::SerdeMapVisitor for event fields.
  • Use a new field named {field}.sources to record the sources as a list.
  • Add a unit test.

@stijnherfst
Copy link

It would be great to have this feature in.

@LucioFranco
Copy link
Member

Closing this one in favor of #3317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants