Open
Conversation
raldone01
requested review from
a team,
carllerche,
davidbarsky and
hawkw
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I noticed we had some code at work that was creating spans with e.g.
info_span!()and not doing anything with the spans. This seems like it should be prevented.Please let me know if I'm wrong about this and there are useful use-cases for creating and not using Spans and I'll close this PR.
Solution
Add a
#[must_use]totracing::Span.Adding
must_usetoSpanis a little bit of a pain in the test suite but I think it would be good for the end user since spans are meant to be entered.Same as #3234 but targeting
v0.2.xinstead ofmain.