Open
Conversation
…via `ExtraFields` trait
2502df5 to
05c8dca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a way for users to provide a generic field injector implementation to augment json log events.
Motivation
This solves #1531 by allowing anyone to extend the fields of the JSON records as they see fit.
This is a common problem across the rust ecosystem and often ends up with hacking or building a new formatter directly to get
trace_idandspan_idinto logs.Solution
Thanks to this it is now possible to build things like a
trace_idinjector:The trait is kept generic and given direct access to the serializer, event and context for both efficiency and flexibility.