ast: Simplification (and maybe fix) in ctypeInheritanceCall#6822
Draft
ast: Simplification (and maybe fix) in ctypeInheritanceCall#6822
ctypeInheritanceCall#6822Conversation
Replaced `!isCallToOUterRef() && !isField()` by `isConstructur()`, which is IMHO the main point here, a constructor sets a specific target type, while for a field or function, the result type is important.
| res, that, null); | ||
| var oc = o == null || o.isUniverse() | ||
| ? Universe.instance | ||
| : target instanceof AbstractCall ac && ac.calledFeature().isConstructor() |
Member
There was a problem hiding this comment.
What about choices? Maybe even:
Suggested change
| : target instanceof AbstractCall ac && ac.calledFeature().isConstructor() | |
| : target instanceof AbstractCall ac && ac.calledFeature().definesType() |
Member
Author
There was a problem hiding this comment.
A choice should not be called, so this should be equivalent in the case of no reported errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced
!isCallToOUterRef() && !isField()byisConstructur(), which is IMHO the main point here, a constructor sets a specific target type, while for a field or function, the result type is important.This is an attempt to simplify the code introduced in #6818.