Skip to content

Conversation

AllForNothing
Copy link

@AllForNothing AllForNothing commented Sep 19, 2025

  1. Remove the duplicated zh-Hans.json file
  2. Supplemented the missing entries in zh.json(Based on en.json)and completed the translation
  3. Modified the i18n-related code so that the Chinese language option can be displayed on the UI
  4. Add .history to the gitignore file

Great Project!!!

I noticed that the project already had a zh.json file, but the UI didn't have a Chinese language option, so I created this pull request.
Typically, the Simplified Chinese locale uses zh-CN, but to align with the project's coding style, I used zh for Simplified Chinese.
I did a quick review of zh.json. While it's not very detailed, I can confirm that the Chinese in it is understandable to Chinese people.
Also, I can continue to contribute to the Chinese translation.

Copy link
Member

@dzienisz dzienisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. To be able to merge please run eslint locally and apply fixes

@AllForNothing
Copy link
Author

Thank you for this PR. To be able to merge please run eslint locally and apply fixes

@dzienisz code format issue fixed. Kindly help review the PR again

@Anty0
Copy link
Collaborator

Anty0 commented Sep 22, 2025

@AllForNothing Hi! Thanks for the PR! ^^

Unfortunately, we use Tolgee to handle translations (yes, Tolgee is using Tolgee for translations 😁). This means all those translation JSONs are generated, and your changes will be overwritten by our build process.

@JanCizmar What is the best way to proceed with this PR?

@AllForNothing
Copy link
Author

@AllForNothing Hi! Thanks for the PR! ^^

Unfortunately, we use Tolgee to handle translations (yes, Tolgee is using Tolgee for translations 😁). This means all those translation JSONs are generated, and your changes will be overwritten by our build process.

@JanCizmar What is the best way to proceed with this PR?

Thanks for the info. Kindly advise what I should do next.

@JanCizmar
Copy link
Contributor

JanCizmar commented Sep 23, 2025

Hey! Can you please connect with Marketa Cizmar via our community slack? She will give you instructions, how to contribute to the localization. :) https://tolg.ee/slack

Thanks a lot for the contribution btw. ❤️

@AllForNothing
Copy link
Author

Hey! Can you please connect with Marketa Cizmar via our community slack? She will give you instructions, how to contribute to the localization. :) https://tolg.ee/slack

Thanks a lot for the contribution btw. ❤️

Hi! Thanks for your message. I’ll join the Slack and contact Marketa Cizmar for localization instructions. Looking forward to contributing!

@AllForNothing
Copy link
Author

Hey! Can you please connect with Marketa Cizmar via our community slack? She will give you instructions, how to contribute to the localization. :) https://tolg.ee/slack

Thanks a lot for the contribution btw. ❤️

@JanCizmar, I am unable to reach this Slack workspace. Should I be invited to ? My Slack account email "[email protected]"
image

@Anty0
Copy link
Collaborator

Anty0 commented Sep 27, 2025

@AllForNothing You should be able to join using the https://tolg.ee/slack link. I've also invited you directly. Hope it works for you this time!

@AllForNothing
Copy link
Author

Marketa Cizmar

Thanks for the invitation!!! I've joined the Slack workspace!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants