-
-
Notifications
You must be signed in to change notification settings - Fork 303
feat: display language option for Chinese on the UI #3249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0225cde
to
4549816
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR. To be able to merge please run eslint locally and apply fixes
Signed-off-by: Shijun Sun <[email protected]>
4549816
to
fa58a2e
Compare
@dzienisz code format issue fixed. Kindly help review the PR again |
@AllForNothing Hi! Thanks for the PR! ^^ Unfortunately, we use Tolgee to handle translations (yes, Tolgee is using Tolgee for translations 😁). This means all those translation JSONs are generated, and your changes will be overwritten by our build process. @JanCizmar What is the best way to proceed with this PR? |
Thanks for the info. Kindly advise what I should do next. |
Hey! Can you please connect with Marketa Cizmar via our community slack? She will give you instructions, how to contribute to the localization. :) https://tolg.ee/slack Thanks a lot for the contribution btw. ❤️ |
Hi! Thanks for your message. I’ll join the Slack and contact Marketa Cizmar for localization instructions. Looking forward to contributing! |
@JanCizmar, I am unable to reach this Slack workspace. Should I be invited to ? My Slack account email "[email protected]" |
@AllForNothing You should be able to join using the https://tolg.ee/slack link. I've also invited you directly. Hope it works for you this time! |
Thanks for the invitation!!! I've joined the Slack workspace!!! |
Great Project!!!
I noticed that the project already had a zh.json file, but the UI didn't have a Chinese language option, so I created this pull request.
Typically, the Simplified Chinese locale uses zh-CN, but to align with the project's coding style, I used zh for Simplified Chinese.
I did a quick review of zh.json. While it's not very detailed, I can confirm that the Chinese in it is understandable to Chinese people.
Also, I can continue to contribute to the Chinese translation.