Emotes Unintentionally Being Ignored#26
Open
justinrusso wants to merge 5 commits intotomaarsen:masterfrom
Open
Emotes Unintentionally Being Ignored#26justinrusso wants to merge 5 commits intotomaarsen:masterfrom
justinrusso wants to merge 5 commits intotomaarsen:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, some emotes in Twitch chat were getting ignored by the bot unintentionally. The logic used to filter out bit messages were catching these emotes - perhaps new emotes started to use the
emotesv2_prefix?I've refactored the logic to just look for the
bitstag in the message. If it contains thebitstag, which only seems to appear if it is a bit message, the message is then ignored. Otherwise, it is assumed to be OK for further processing.