Answer:1 - straightforward, no usage of ngTemplateOutlet#1175
Answer:1 - straightforward, no usage of ngTemplateOutlet#1175zealotrahl wants to merge 6 commits intotomalaforge:mainfrom
Conversation
Test branch change
zealotrahl
force-pushed
the
projection-01
branch
from
e06cdd4 to
459e831
Compare
|
I can't get fully idea of ngTemplateOutlet, to me it looks too complicated; I believe this is straightforward and simple solution having the constraints mentioned; |
zealotrahl
changed the title
|
Indeed your solution works, but if I make the exercise more complex like asking to add an icon for the city card only or a edit button or anything else, you will have a hard time and you will need to add a lot of condition inside your component. |
| }; | ||
| }); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Don't use imperative coding, try to code in a declaration way, which means try to do the same but without the subscribe.
And use signals. 😉
There was a problem hiding this comment.
Hi, thank you, declarative seems like a trend in Angular, especially with signals.
I will try to adapt it. I understand that such a style is safer than mutating the state.
| <ng-content select="[card-img]"></ng-content> | ||
| <section> | ||
| <app-list-item | ||
| *ngFor="let item of list" |
There was a problem hiding this comment.
no more ngfor, use the new control flow
| private teacherStore: TeacherStore, | ||
| private studentStore: StudentStore, | ||
| ) {} | ||
| @Output() deleteItemEvent = new EventEmitter<number>(); |
There was a problem hiding this comment.
use the new input and output function.
|
Don't hesitate to ask question if something is unclear |
|
This pull request is stale because it has been open for 15 days with no activity. |
zealotrahl
force-pushed
the
projection-01
branch
from
86688b2 to
029b2eb
Compare
Thank you, I will review ng ngTemplateOutlet, I honestly struggle to understand the use case for it yet |
2 participants
Checklist for challenge submission