Skip to content

Remove non-existing classes to reflect website changes#244

Merged
FriedrichFroebel merged 1 commit intotomasbedrich:masterfrom
BelKed:website_changes
Mar 7, 2026
Merged

Remove non-existing classes to reflect website changes#244
FriedrichFroebel merged 1 commit intotomasbedrich:masterfrom
BelKed:website_changes

Conversation

@BelKed
Copy link
Copy Markdown
Contributor

@BelKed BelKed commented Mar 7, 2026

On the website they've removed some classes that were used for locating the required elements, removing them from the code as well

I'm not going to update the tests as there seems to be an issue with re-recording test cassettes

@FriedrichFroebel
Copy link
Copy Markdown
Collaborator

Thanks for the report. I guess the risk for matching the wrong elements here is still low?

I'm not going to update the tests as there seems to be an issue with re-recording test cassettes

Is this one of the known issues or a new one?

@BelKed
Copy link
Copy Markdown
Contributor Author

BelKed commented Mar 7, 2026

The changes to the website doesn't happen that often from what I can see, so it's not that risky :)

Issues with tests are recorded way back to #194
When I'll have more time, I'll maybe have a look at it ;)

@FriedrichFroebel FriedrichFroebel merged commit 6961093 into tomasbedrich:master Mar 7, 2026
15 checks passed
@BelKed BelKed deleted the website_changes branch March 7, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants