Skip to content

Conversation

@tomchor
Copy link
Owner

@tomchor tomchor commented Apr 23, 2025

CliMA/Oceananigans.jl#4046 (released with Oceananigans version 0.96) introduced new default names for the dimensions. This PR updates pynanigans to account for that.

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.23%. Comparing base (c1e8dd6) to head (cc3030d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pynanigans/utils.py 50.00% 2 Missing ⚠️
pynanigans/grids.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main       #5       +/-   ##
===========================================
+ Coverage   63.15%   76.23%   +13.07%     
===========================================
  Files           4        4               
  Lines         114      101       -13     
===========================================
+ Hits           72       77        +5     
+ Misses         42       24       -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tomchor tomchor merged commit 7d94ec0 into main May 15, 2025
4 checks passed
@tomchor tomchor deleted the tc/update-names branch May 15, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants