LibraryInfo for easy library base address getting. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommoa
requested changes
Jan 26, 2021
| /// Returns other error when closing the handle fails. | ||
| /// | ||
| /// [`set_offset`]: trait.Memory.html#tymethod.set_offset | ||
| fn libs_iter(&self) -> std::io::Result<Vec<LibraryInfo>>; |
There was a problem hiding this comment.
One potential option instead of returning Result<Vec<LibraryInfo>> would be creating an iterating class (say LibraryIter<'a>, which implements Iterator<Item=LibraryInfo>) and implementing it for each OS. That's probably the most "rust-like" method of doing what you want.
|
|
||
| let snapshot: winapi::um::winnt::HANDLE; | ||
| unsafe { | ||
| snapshot = tlhelp32::CreateToolhelp32Snapshot(tlhelp32::TH32CS_SNAPPROCESS, 0); |
There was a problem hiding this comment.
Have you checked how this deals with processes with unicode in them? The impression I get from https://docs.microsoft.com/en-us/windows/win32/intl/conventions-for-function-prototypes is that the ...W functions should be used, and then converted to utf-8 using std::os::windows::ffi::OsStringExt::from_wide().
tommoa
force-pushed
the
master
branch
3 times, most recently
from
5573198 to
bf01b32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the requested changes on #4 would have required me to undo a lot of stuff, I decided to make some new pull requests.
The
GetLibraryInfotrait now also returns an iterator, in case someone is interested in listing what modules are loaded at all. Sadly it returns aVec<LibraryInfo>, not an Iterator directly, because...Box<dyn Iterator<Item = LibraryInfo>>would be too ugly I think? I don't know, I'm still new to rust and have chosen this project to be a bit of my victim for me to learn it :D.