Remove suppression_mappings.txt#2229
Remove suppression_mappings.txt#2229DanShaders wants to merge 9 commits intoton-blockchain:testnetfrom
Conversation
|
I can’t run any local git commands in this environment right now because the sandbox is failing before command execution ( Please paste the outputs of these commands, and I’ll do the commit-by-commit review immediately: git log --oneline 93c0d83051358a555305f3d0b94e9cf04cfd4761...2abfdf89e88625c40a44c2d4adc4826485a018db
git show --stat --patch --find-renames --find-copies <commit1>
git show --stat --patch --find-renames --find-copies <commit2>
# ...for each commit in that rangeIf easier, a single combined diff also works: git diff --find-renames --find-copies 93c0d83051358a555305f3d0b94e9cf04cfd4761...2abfdf89e88625c40a44c2d4adc4826485a018db |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2abfdf89e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| // FIXME: Remove once RocksDB stops triggering this warning. | ||
| #pragma GCC diagnostic push | ||
| #pragma GCC diagnostic ignored "-Wimplicit-int-float-conversion" |
There was a problem hiding this comment.
#pragma GCC diagnostic ignored "-Wimplicit-int-float-conversion" is not a recognized warning name in GCC, so GCC emits a -Wpragmas warning on this line; with -Wall enabled (and especially with TON_WERROR_BUILD), that turns into a build break for GCC configurations. Please gate this suppression to Clang (or use a GCC-supported warning flag) so this file remains warning-clean across supported compilers.
Useful? React with 👍 / 👎.
A better solution will be to upstream a fix but in the meantime, this will be good enough. Since this is the last suppressed warning, the commit also deletes suppression_mappings.txt and CMake glue for it.
|
I can’t reliably review this PR from the current environment because:
Please provide one of these, and I’ll do the full atomic commit review immediately:
git log --oneline 9664bba10039ebc176eca477ab2f248e9eed2ef2...4421f0e3d0d4dc1f879f945f56f25b91653161deplus, for each commit in that list: git show --patch --stat --find-renames <commit_sha>
|
2 participants
We are officially warning free!
Also includes two random commits I didn't feel like creating a separate PR for.