chore(ci): decrease the amount of scripting in bouncer.yml and stop posting messages on new pushes
#1504
Conversation
… posting messages on new pushes
|
Skipping AI review because no docs changes in md, mdx, or docs.json |
| MAX_ADDITIONS_FORKS: 500 | ||
| # on rare occasions maintainers need to edit a lot of things at once | ||
| MAX_ADDITIONS_DIRECT_BRANCHES: 800 | ||
| MAX_ADDITIONS_DIRECT_BRANCHES: 1000 |
There was a problem hiding this comment.
Why do we keep raising this limit? We discussed internally this should be 500 both for external and internal PRs.
There was a problem hiding this comment.
Yeah, but if we don't make this CI mandatory (and we don't), there's a non-zero chance that folks would neglect other checks, thinking that they can merge stuff even when CI fails. I don't want that to happen, and for the time being, made a slightly larger leeway to see whether it's worth it. We can always roll back or hard cap everyone to 500 once the contribution and maintenance processes are more or less settled.
Oh, and we have a bunch (~60) of now-removed stub pages waiting to be written. Let's come back in, say, a month and change constraints if necessary :)
Closes #1497.
Stopped posting messages on new pushes in the PR — they are in the workflow outputs now. This significantly reduced the JS code used in the workflow, to the point where it's not really a win even if we manage to extract it elsewhere.
Also made the wording of workflow outputs be a bit smoother — no more "until then your PR is doomed and you're failure" type stuff. It's now more chill and explanatory, but still concise.