fix: array elements starting with number followed by text parsed as string#57
Merged
shreyasbhat0 merged 2 commits intomainfrom Mar 4, 2026
Merged
Conversation
…as string When parsing inline array values, numbers followed by string tokens (e.g., `1.0 something`) were incorrectly truncated to just the number. The fix checks for trailing string tokens after Number/Integer tokens in parse_tabular_field_value() and treats the combined value as a string, matching the behavior of regular field value parsing. Fixes #56
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1.0 somethingwere truncated to just the number (Number(1)) instead of being parsed asString("1 something")parse_tabular_field_value()now checks for trailing string tokens after Number/Integer tokens and treats the combined value as a string, matching the behavior of regular field value parsingTest plan
test_array_element_number_followed_by_stringcovering number+text and pure number casesFixes #56