Use yaml package instead of @yarnpkg/parsers to manipulate yaml#36
Merged
suhdonghwi merged 4 commits intomainfrom Nov 28, 2025
Merged
Use yaml package instead of @yarnpkg/parsers to manipulate yaml#36suhdonghwi merged 4 commits intomainfrom
yaml package instead of @yarnpkg/parsers to manipulate yaml#36suhdonghwi merged 4 commits intomainfrom
Conversation
suhdonghwi
changed the title
yaml package instead of @yarnpkg/parsers' to manipulate yamlyaml package instead of @yarnpkg/parsers to manipulate yaml
parksb
reviewed
Nov 28, 2025
Member
There was a problem hiding this comment.
It seems like the bundle file is not minified. Could you please check? (Unlike yarn build, test creates a non-minified bundle.)
parksb
approved these changes
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the use of
@yarnpkg/parserswith theyamlpackage when manipulating.yarnrc.yml.@yarnpkg/parsersinternally relies onjs-yaml, which strips all comments during parsing and serialization. By switching toyaml, we preserve comments and ensure safer, non-destructive updates to the config file.