Skip to content

feat: Add PHP 8.5 support - #373

Merged
LinnyTheDuck merged 1 commit into
totara:masterfrom
LinnyTheDuck:adding-php-8.5
Jan 29, 2026
Merged

LinnyTheDuck merged 1 commit into
totara:masterfrom
LinnyTheDuck:adding-php-8.5

Conversation

@LinnyTheDuck

@LinnyTheDuck LinnyTheDuck commented Nov 23, 2025 •

Copy link
Copy Markdown
Collaborator

Description

Adding support for the PHP-8.5 container.

Testing Instructions

  1. Check out this pull request
  2. Build the PHP-8.5 container: tbuild PHP-8.5
  3. Up the container: tup PHP-8.5
  4. Test that you can load a T20 site and that you get deprecation notices.
  5. Add an entry for totara85 in your debug server list in PHPStorm.
  6. Add a break point in /login/index.php
  7. Check that the break point is triggered when visiting http://integration.totara85.debug.localhost/login/index.php

Checklist

  • Does what the author says it will do
  • Testing instructions are provided
  • Commit messages make sense and follow the conventional commit standard
  • No identified security issues
  • No identified maintenance issues
  • Any third-party libraries/dependencies use the MIT or Apache 2.0 license
  • Changes made are backwards compatible and will not break existing setups
  • Changes to scripts in the bin/ directory run correctly on both MacOS and WSL
  • Changes to containers can be built locally sucessfully (e.g. via tbuild container && tup container)
  • Containers/images are compatible with both AMD64 (Windows) and ARM64 (MacOS)
  • Changes made to config.php are compatible with our oldest supported Totara version, our newest Totara version, and Moodle

@markometcalfe markometcalfe changed the title Adding php 8.5 feat: Add PHP 8.5 support Nov 24, 2025

@markometcalfe markometcalfe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - will need to wait until the new MSSQL driver is out and update the Dockerfile

@LinnyTheDuck

Copy link
Copy Markdown
Collaborator Author

Looking good - will need to wait until the new MSSQL driver is out and update the Dockerfile

This is not needed as MSSQL 2025 will not be supported in future Totara versions.

@codyfinegan

Copy link
Copy Markdown
Member

@angelakuznetsova Could you give a go at testing it?

@jakub-krauz-totara

Copy link
Copy Markdown

Oh nooo! I wish I knew about this PR earlier. I just implemented pretty much the same for OPS-3732 :-D

https://github.com/totara/totara-docker-dev/tree/OPS-3732/php-8.5

@LinnyTheDuck

Copy link
Copy Markdown
Collaborator Author

Oh nooo! I wish I knew about this PR earlier. I just implemented pretty much the same for OPS-3732 :-D

https://github.com/totara/totara-docker-dev/tree/OPS-3732/php-8.5

Noted, and I've updated the packages that are now supported by 8.5

@LinnyTheDuck
LinnyTheDuck merged commit 8d46fdd into totara:master Jan 29, 2026
13 checks passed
@LinnyTheDuck
LinnyTheDuck deleted the adding-php-8.5 branch January 29, 2026 22:54
@TotaraAdmin

Copy link
Copy Markdown

🎉 This PR is included in version 1.22.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants