Repository navigation
feat: Add PHP 8.5 support - #373
Conversation
1fa963e to
81dd4e4
Compare
markometcalfe
left a comment
There was a problem hiding this comment.
Looking good - will need to wait until the new MSSQL driver is out and update the Dockerfile
This is not needed as MSSQL 2025 will not be supported in future Totara versions. |
|
@angelakuznetsova Could you give a go at testing it? |
81dd4e4 to
90481d3
Compare
|
Oh nooo! I wish I knew about this PR earlier. I just implemented pretty much the same for OPS-3732 :-D https://github.com/totara/totara-docker-dev/tree/OPS-3732/php-8.5 |
90481d3 to
712b56e
Compare
Noted, and I've updated the packages that are now supported by 8.5 |
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
Adding support for the PHP-8.5 container.
Testing Instructions
tbuild PHP-8.5tup PHP-8.5/login/index.phphttp://integration.totara85.debug.localhost/login/index.phpChecklist
bin/directory run correctly on both MacOS and WSLtbuild container && tup container)config.phpare compatible with our oldest supported Totara version, our newest Totara version, and Moodle