Skip to content

fix: Update ngrok regex to include .dev domains - #383

Merged
LinnyTheDuck merged 1 commit into
totara:masterfrom
jay-watt:ngrok-dev-domain
Apr 16, 2026
Merged

LinnyTheDuck merged 1 commit into
totara:masterfrom
jay-watt:ngrok-dev-domain

Conversation

@jay-watt

Copy link
Copy Markdown

Description

Add .dev domains to the ngrok hostname regex. The free tier uses ngrok-free.dev for automatically assigned URLs, while paid users may use ngrok.dev. Previously only .app and .pizza domains were matched, meaning free-tier ngrok tunnels would not be recognised.

Testing Instructions

  1. Check out this pull request
  2. Start a ngrok free-tier tunnel which will generate a ngrok-free.dev URL
  3. Verify the tunnel is recognised and behaves correctly
  4. Use a paid account to repeat steps 2-3 with a ngrok.dev URL
  5. Use a paid account to confirm existing ngrok.app and ngrok.pizza URLs still work as before

Checklist

  • Does what the author says it will do
  • Testing instructions are provided
  • Commit messages make sense and follow the conventional commit standard
  • No identified security issues
  • No identified maintenance issues
  • Any third-party libraries/dependencies use the MIT or Apache 2.0 license
  • Changes made are backwards compatible and will not break existing setups
  • Changes to scripts in the bin/ directory run correctly on both MacOS and WSL
  • Changes to containers can be built locally sucessfully (e.g. via tbuild container && tup container)
  • Containers/images are compatible with both AMD64 (Windows) and ARM64 (MacOS)
  • Changes made to config.php are compatible with our oldest supported Totara version, our newest Totara version, and Moodle

@LinnyTheDuck
LinnyTheDuck self-requested a review March 11, 2026 00:31
@LinnyTheDuck
LinnyTheDuck merged commit 0a6a59c into totara:master Apr 16, 2026
5 checks passed
@TotaraAdmin

Copy link
Copy Markdown

🎉 This PR is included in version 1.24.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants