Repository navigation
feat: Removed xdebug from normal PHP 8.4 and 8.5 containers, bumped xebug versions to latest patch release - #395
Closed
chris-snyder-totara wants to merge 1 commit into
Closed
chris-snyder-totara wants to merge 1 commit into
chris-snyder-totara wants to merge 1 commit into
Conversation
Author
|
New PR with proper branch name for issue. |
chris-snyder-totara
force-pushed
the
378-xdebug
branch
from
June 4, 2026 02:12
ed7e2a0 to
7662810
Compare
…debug versions to latest patch release to fix segfault issue
chris-snyder-totara
force-pushed
the
378-xdebug
branch
from
June 5, 2026 01:49
7662810 to
e4ec569
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes xdebug extension install from normal php-8.4 and php-8.5 containers, and switches dependency around so that php-debug containers depend on standard php containers, rather than vice versa.
Also bumps xdebug version to latest patch releases:
php8.4-debug to xdebug-3.4.7 (to fix segfault issues)
php8.5-debug to xdebug-3.5.1 (to fix Windows performance)
Testing Instructions
server/totara/notification/tests/webapi_toggle_notifiable_event_v2_test.phppasses without segfaultserver/totara/notification/tests/webapi_toggle_notifiable_event_v2_test.phppasses without segfaultChecklist
bin/directory run correctly on both MacOS and WSLtbuild container && tup container)config.phpare compatible with our oldest supported Totara version, our newest Totara version, and Moodle