Skip to content

feat: Removed xdebug from normal PHP 8.4 and 8.5 containers, bumped xebug versions to latest patch release - #395

Closed
chris-snyder-totara wants to merge 1 commit into
totara:masterfrom
chris-snyder-totara:378-xdebug
Closed

chris-snyder-totara wants to merge 1 commit into
totara:masterfrom
chris-snyder-totara:378-xdebug

Conversation

@chris-snyder-totara

Copy link
Copy Markdown

Description

Removes xdebug extension install from normal php-8.4 and php-8.5 containers, and switches dependency around so that php-debug containers depend on standard php containers, rather than vice versa.

Also bumps xdebug version to latest patch releases:

php8.4-debug to xdebug-3.4.7 (to fix segfault issues)
php8.5-debug to xdebug-3.5.1 (to fix Windows performance)

Testing Instructions

  1. Check out this pull request
  2. Rebuild php-8.4 and php-8.4-debug containers
  3. tup php-8.4
  4. Confirm that php-8.4-debug does NOT start at the same time
  5. Test using tzsh php-8.4:
  6. Confirm that php -i does not list any xdebug settings
  7. Confirm that the unit test server/totara/notification/tests/webapi_toggle_notifiable_event_v2_test.php passes without segfault
  8. tup php-8.4-debug
  9. Test using tzsh php-8.4-debug:
  10. Confirm that php -i shows xdebug configured and enabled
  11. Confirm that the unit test server/totara/notification/tests/webapi_toggle_notifiable_event_v2_test.php passes without segfault

Checklist

  • Does what the author says it will do
  • Testing instructions are provided
  • Commit messages make sense and follow the conventional commit standard
  • No identified security issues
  • No identified maintenance issues
  • Any third-party libraries/dependencies use the MIT or Apache 2.0 license
  • Changes made are backwards compatible and will not break existing setups
  • Changes to scripts in the bin/ directory run correctly on both MacOS and WSL
  • Changes to containers can be built locally sucessfully (e.g. via tbuild container && tup container)
  • Containers/images are compatible with both AMD64 (Windows) and ARM64 (MacOS)
  • Changes made to config.php are compatible with our oldest supported Totara version, our newest Totara version, and Moodle

@chris-snyder-totara

Copy link
Copy Markdown
Author

New PR with proper branch name for issue.

…debug versions to latest patch release to fix segfault issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant