Skip to content

Added 60dB integration - #53

Open
manishEMS47 wants to merge 1 commit into
tover0314-w:mainfrom
manishEMS47:main
Open

Added 60dB integration#53
manishEMS47 wants to merge 1 commit into
tover0314-w:mainfrom
manishEMS47:main

Conversation

@manishEMS47

Copy link
Copy Markdown

Summary

Change Type

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • CI / Infrastructure

Changes

Test Plan

  • Tested locally on [OS]
  • npm run build passes
  • npx vitest run passes
  • cargo clippy -- -D warnings passes
  • No regressions in existing functionality

Screenshots / Recordings

Related Issues

@manishEMS47
manishEMS47 requested a review from tover0314-w as a code owner June 9, 2026 09:19
@tover0314-w

Copy link
Copy Markdown
Owner

Thanks for the contribution. I am not merging this yet because the PR adds a new external STT provider but does not include enough validation to make it safe to land: the PR body has no completed test plan, the provider API assumptions need a linked reference or live/manual verification, and the current checks are red/expired. Before this can be merged, please add or document: response format/error handling verification for 60dB, local unit tests for parsing and failure mapping, a provider selector/UI test, and a completed test plan showing at least npm test/build plus Rust tests. Once that is in place, this can be reviewed again.

@tover0314-w

Copy link
Copy Markdown
Owner

Review update: this still should not merge as-is.

The main blocker is at the API boundary: 60dB documents the multipart audio field as audio, but this PR uses file in the request shape. That means the provider can appear wired in the UI while failing against the real API.

Before this can land, please update and verify:

  • use multipart field audio
  • align limits with current 60dB docs: 25MB and 10 minutes
  • add tests or an HTTP mock that asserts the request shape
  • document one valid-key smoke test and one invalid-key/auth failure test

This was not merged into the local issue-remediation branch I just validated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants