Fix failures introduced by f859fb8 #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change in f859fb8 assumed that GitHub would respond to API requests to /organizations/$org_name/team/$team_id, but it doesn't. The only supported URL seems to be /organizations/$org_id/team/$team_id, so we need to somehow query the teams using both their org and team IDs. Fortunately GitHub includes an "url" field in the response for listing teams that can be used to obtain the correct path. Use this field to determine the correct URL and adjust the test harness to match GitHub's actual behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in f859fb8 assumed that GitHub would respond to API requests to
/organizations/$org_name/team/$team_id, but it doesn't. The only supported URL seems to be/organizations/$org_id/team/$team_id, so we need to somehow query the teams using both their org and team IDs. Fortunately GitHub includes an "url" field in the response for listing teams that can be used to obtain the correct path.Use this field to determine the correct URL and adjust the test harness to match GitHub's actual behavior.