Skip to content

Add data flow solver - #1572

Open
wingertge wants to merge 7 commits into
tracel-ai:mainfrom
wingertge:feat/dataflow-solver
Open

Add data flow solver#1572
wingertge wants to merge 7 commits into
tracel-ai:mainfrom
wingertge:feat/dataflow-solver

Conversation

@wingertge

Copy link
Copy Markdown
Collaborator

Adds a new solver for DFAs and re-implements the upstream SCCP implementation using the solver as a test case.
The upstream version already handled 99% of all cases so performance impact for the SCCP replacement is negligible (possibly 0.3% but it might be margin of error), but the solver drastically simplifies more impactful future optimizations like partial redundancy elimination, common subexpression elimination, load after store, etc. SCCP just serves as a good way to test it, and it's technically slightly better because it now supports region args and results.

Adds the upstream SCCP tests plus some extra region-specific ones to cubecl-opt.

@nathanielsimard nathanielsimard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants