-
Notifications
You must be signed in to change notification settings - Fork 9
[Feature] Added failure only notifications #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[Feature] Added failure only notifications #13
Conversation
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks good, I'm just curious about the notification activation change. There are some things I want to change, like refactoring the part in |
|
I guessed that you would have wanted it as a filter. However it is not clear to me if you intend to use a single filter or combine multiple filters to compute whether the notification should be displayed, and thus I went for the basic approach 😄. |
|
I need to add a different kind of filter – a Don't worry about the fact that the pull request can't be merged automatically—I have the conflict resolved locally. |
Cool to hear that. I didn't noticed the conflict, and I'm not sure how I generated it, I thought I started from the tip of master. Btw, a nit pick: it would be great if the |
You did, I just had some local commits that I forgot to push. |
See #11.