Conversation
and fixed GET /doc/:id/title
nleanba
left a comment
nleanba
left a comment
There was a problem hiding this comment.
The changes are too big for me to properly review them all -- I will take your word if you say you’ve tested it and it all works.
I have however commented on some smaller issues in the changed code.
src/server/server.ts
Outdated
| } catch (error) { | ||
| let message; | ||
| if (error instanceof Deno.errors.PermissionDenied) { | ||
| message = "Got “Permission Denied” trying to access the file on disk.\n\n Please run ```docker exec -u 0 [name of backend-container] chmod -R a+r ./blobs/ rdf.ttl``` on the host server to fix this and similar issues for the future." |
There was a problem hiding this comment.
Is this error message still accurate / current?
There was a problem hiding this comment.
The error could come from any handler. The extended error message seems potentially useful, mainly in the scenario of mounted host dirs. I suggest keeping it.
.devcontainer/devcontainer.json
Outdated
|
|
||
| "containerEnv": { | ||
| "TRIDOC_PWD": "pw123", | ||
| "OCR_LANG": "deu" |
There was a problem hiding this comment.
A change would require recreating all containers of the multi-container dev container. A normal rebuild / full rebuild leaves the fuseki contatiner untouched. @nleanba, do you know how to do that? Because we should instruct users on what needs to be done for changes to have effect (or else not present the option to change).
…t the fallback is hardcoded in shell-script
2 participants
A deno 2 based backend worki§ng with fuseki 5.4.0 storing blobs based on their ipfs digest.