Skip to content

fix #2629: avoid multiple rerenders when tags is an array #2624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix #2629: avoid multiple rerenders when tags is an array #2624

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d1a7742
fix: avoid multiple rerenders when tags is an array
tonibardina Oct 22, 2025
9706a57
Merge branch 'main' into fix/tags_array_infinite_rerenders
tonibardina Oct 22, 2025
5307cb9
Merge branch 'main' into fix/tags_array_infinite_rerenders
tonibardina Oct 23, 2025
49d6920
Merge branch 'main' into fix/tags_array_infinite_rerenders
tonibardina Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/react-hooks/src/hooks/useRealtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,9 @@ export function useRealtimeRunsWithTag<TTask extends AnyTask>(

const apiClient = useApiClient(options);

const stableTag = Array.isArray(tag)
? JSON.stringify([...tag].sort())
: tag;
const triggerRequest = useCallback(async () => {
try {
if (!apiClient) {
Expand Down Expand Up @@ -459,7 +462,7 @@ export function useRealtimeRunsWithTag<TTask extends AnyTask>(
abortControllerRef.current = null;
}
}
}, [tag, mutateRuns, runsRef, abortControllerRef, apiClient, setError]);
}, [stableTag, mutateRuns, runsRef, abortControllerRef, apiClient, setError]);

useEffect(() => {
if (typeof options?.enabled === "boolean" && !options.enabled) {
Expand All @@ -471,7 +474,7 @@ export function useRealtimeRunsWithTag<TTask extends AnyTask>(
return () => {
stop();
};
}, [tag, stop, options?.enabled]);
}, [stableTag, stop, options?.enabled]);

return { runs: runs ?? [], error, stop };
}
Expand Down