Skip to content

chore(helm): increase default clickhouse resources #2635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
Merged

chore(helm): increase default clickhouse resources #2635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hosting/k8s/helm/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: trigger
description: The official Trigger.dev Helm chart
type: application
version: 4.0.4
version: 4.0.5
appVersion: v4.0.4
home: https://trigger.dev
sources:
Expand Down
10 changes: 6 additions & 4 deletions hosting/k8s/helm/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,14 +656,16 @@ helm upgrade --install trigger . \
cpu: 250m
memory: 512Mi

# ClickHouse can be very resource intensive, so we recommend setting limits and requests accordingly
# Note: not doing this can cause OOM crashes which will cause issues across many different features
clickhouse:
resources:
limits:
cpu: 1000m
memory: 2Gi
cpu: 4000m
memory: 16Gi
requests:
cpu: 500m
memory: 1Gi
cpu: 2000m
memory: 8Gi

supervisor:
resources:
Expand Down
10 changes: 6 additions & 4 deletions hosting/k8s/helm/values-production-example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,15 @@ clickhouse:
enabled: true
size: 100Gi
storageClass: "fast-ssd"
# ClickHouse can be very resource intensive, so we recommend setting limits and requests accordingly
# Note: not doing this can cause OOM crashes which will cause issues across many different
Comment on lines +81 to +82
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Complete the truncated comment.

Line 82's comment appears to end mid-sentence: "...which will cause issues across many different" lacks a conclusion. Finish the thought to clarify the scope of OOM impact (e.g., "...across many different components" or "...across many different services").

🤖 Prompt for AI Agents 
In hosting/k8s/helm/values-production-example.yaml around lines 81 to 82, the
comment is truncated and ends with "which will cause issues across many
different"; complete the sentence to clarify the impact of OOM crashes — for
example, change it to "which will cause OOM crashes which will cause issues
across many different components and services in the cluster." Update the
comment text in place to finish the thought and make the scope explicit.

resources:
limits:
cpu: 1000m
memory: 2Gi
cpu: 4000m
memory: 16Gi
requests:
cpu: 500m
memory: 1Gi
cpu: 2000m
memory: 8Gi

# Production S3-compatible object storage
s3:
Expand Down
36 changes: 16 additions & 20 deletions hosting/k8s/helm/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,7 @@ webapp:
defaultOrgExecutionConcurrencyLimit: 300

# Resources
resources:
{}
resources: {}
# Example resource configuration:
# limits:
# cpu: 1000m
Expand All @@ -125,8 +124,7 @@ webapp:
postgres: true # Set to false to disable DATABASE_HOST env var (overrides postgres.external.connectivityCheck)

# Extra environment variables for webapp
extraEnvVars:
[]
extraEnvVars: []
# - name: CUSTOM_VAR
# value: "custom-value"
# - name: SECRET_VAR
Expand All @@ -140,8 +138,7 @@ webapp:
# value: "/etc/ssl/certs/postgres-ca.crt"

# Extra volumes for the webapp pod
extraVolumes:
[]
extraVolumes: []
# - name: config-volume
# configMap:
# name: my-config
Expand All @@ -158,8 +155,7 @@ webapp:
# path: postgres-ca.crt

# Extra volume mounts for the webapp container
extraVolumeMounts:
[]
extraVolumeMounts: []
# - name: config-volume
# mountPath: /etc/config
# readOnly: true
Expand Down Expand Up @@ -248,8 +244,7 @@ webapp:
paths:
- path: /
pathType: Prefix
tls:
[]
tls: []
# - secretName: trigger-tls
# hosts:
# - trigger.local
Expand Down Expand Up @@ -322,8 +317,7 @@ supervisor:
role:
name: ""
# Extra environment variables for Supervisor
extraEnvVars:
[]
extraEnvVars: []
# - name: CUSTOM_VAR
# value: "custom-value"

Expand Down Expand Up @@ -520,8 +514,7 @@ electric:
url: "" # For example: "http://electric:3000"

# Extra environment variables for Electric
extraEnvVars:
[]
extraEnvVars: []
# - name: CUSTOM_VAR
# value: "custom-value"

Expand Down Expand Up @@ -553,6 +546,12 @@ clickhouse:
persistence:
enabled: true
size: 10Gi

## ClickHouse resource requests and limits
## ref: http://kubernetes.io/docs/concepts/configuration/manage-compute-resources-container/
## @param resourcesPreset Set container resources according to one common preset (allowed values: none, nano, micro, small, medium, large, xlarge, 2xlarge). This is ignored if resources is set (resources is recommended for production).
## More information: https://github.com/bitnami/charts/blob/main/bitnami/common/templates/_resources.tpl#L15
resourcesPreset: "xlarge"
resources: {}

# External ClickHouse connection (when deploy: false)
Expand Down Expand Up @@ -736,8 +735,7 @@ registry:
successThreshold: 1

# Extra environment variables for Registry
extraEnvVars:
[]
extraEnvVars: []
# - name: CUSTOM_VAR
# value: "custom-value"

Expand All @@ -763,8 +761,7 @@ registry:
paths:
- path: /
pathType: Prefix
tls:
[]
tls: []
# - secretName: registry-tls
# hosts:
# - registry.local
Expand All @@ -786,8 +783,7 @@ telemetry:

# Extra Kubernetes manifests
# This allows you to add additional Kubernetes resources that will be deployed with the chart
extraManifests:
[]
extraManifests: []
# - apiVersion: v1
# kind: ConfigMap
# metadata:
Expand Down