Skip to content

Fix assert_defined#15114

Closed
cgcgcg wants to merge 7 commits intotrilinos:developfrom
cgcgcg:fixAssertDefined
Closed

Fix assert_defined#15114
cgcgcg wants to merge 7 commits intotrilinos:developfrom
cgcgcg:fixAssertDefined

Conversation

@cgcgcg
Copy link
Copy Markdown
Contributor

@cgcgcg cgcgcg commented Apr 9, 2026

Motivation

It looks like assert_defined only asserts that the first variable is defined..

cgcgcg added 7 commits April 8, 2026 21:28
Signed-off-by: Christian Glusa <caglusa@sandia.gov>
Signed-off-by: Christian Glusa <caglusa@sandia.gov>
Signed-off-by: Christian Glusa <caglusa@sandia.gov>
Signed-off-by: Christian Glusa <caglusa@sandia.gov>
Signed-off-by: Christian Glusa <caglusa@sandia.gov>
Signed-off-by: Christian Glusa <caglusa@sandia.gov>
Signed-off-by: Christian Glusa <caglusa@sandia.gov>
@cgcgcg cgcgcg self-assigned this Apr 9, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

CDash for AT2 results [Currently only accessible from Sandia networks]

@cgcgcg cgcgcg marked this pull request as ready for review April 14, 2026 16:57
@cgcgcg cgcgcg requested review from a team as code owners April 14, 2026 16:57
@brian-kelley
Copy link
Copy Markdown
Contributor

@cgcgcg hmm, the tribits function Trilinos/cmake/tribits/core/utils/AssertDefined.cmake is definitely intended to work with multiple arguments. The problem is that it uses a named argument (which takes the first variable name only) instead of variadic ARGV. Your changes here are still correct, but #15132 would let the original code in all the packages work

@cgcgcg
Copy link
Copy Markdown
Contributor Author

cgcgcg commented Apr 16, 2026

Closing in favor of #15132 which actually fixes the macro.

@cgcgcg cgcgcg closed this Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants