React, Angular, Vue - Re-export density and modus types#1060
Open
prashanthr6383 wants to merge 4 commits intomainfrom
Open
React, Angular, Vue - Re-export density and modus types#1060prashanthr6383 wants to merge 4 commits intomainfrom
prashanthr6383 wants to merge 4 commits intomainfrom
Conversation
2 tasks
prashanthr6383
requested a deployment
to
qa-review
GitHub Actions
Waiting
…ould-re-export-the-typesdts
prashanthr6383
requested a deployment
to
qa-review
GitHub Actions
Waiting
Contributor
|
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Re-exports the Density and ModusSize type aliases from the underlying Modus Web Components package so consumers of the React/Angular wrappers can import these types directly from the wrapper packages.
Changes:
- React (v17/v18/v19): re-export
DensityandModusSizefrom the wrapper entrypoints. - Angular (ng17/ng18/ng19): re-export
DensityandModusSizefrom each library’spublic-api.ts. - Updates the React v19 test app badge example to demonstrate typed
size/densityusage.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| integrations/react/v19/src/index.ts | Re-export types from Modus web components for React v19 wrapper consumers |
| integrations/react/v18/src/index.ts | Same type re-export for React v18 wrapper |
| integrations/react/v17/src/index.ts | Same type re-export for React v17 wrapper |
| integrations/react/test-react-v19/src/examples/ModusBadgeExamples.tsx | Demonstrates consuming the re-exported types in an example |
| integrations/angular/ng19/projects/trimble-oss/moduswebcomponents-angular/src/public-api.ts | Re-export types from Modus web components for Angular ng19 wrapper consumers |
| integrations/angular/ng18/projects/trimble-oss/moduswebcomponents-angular/src/public-api.ts | Same type re-export for Angular ng18 wrapper |
| integrations/angular/ng17/projects/trimble-oss/moduswebcomponents-angular/src/public-api.ts | Same type re-export for Angular ng17 wrapper |
ElishaSamPeterPrabhu
previously approved these changes
May 4, 2026
Collaborator
ElishaSamPeterPrabhu
left a comment
ElishaSamPeterPrabhu
left a comment
There was a problem hiding this comment.
Moving to QA @jewel-shajan
prashanthr6383
changed the title
ElishaSamPeterPrabhu
approved these changes
May 5, 2026
Collaborator
ElishaSamPeterPrabhu
left a comment
ElishaSamPeterPrabhu
left a comment
There was a problem hiding this comment.
Moving to QA @Kavin-Trimble @jewel-shajan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Summary of Changes
export types - Density, ModusSize
💭 Type of Change
📋 Test Plan
✅ Self Code Review Checklist
PR authors and reviewers, please verify that all of these items have been completed.
🔗 Work Item
Issue #404