Button: Add xl size#1076
Open
Kavin-Trimble wants to merge 5 commits intomainfrom
Open
Conversation
2 tasks
Contributor
|
There was a problem hiding this comment.
Pull request overview
Adds an xl size option to modus-wc-button, exposing it through the component API, Storybook controls, and button SCSS so consumers can render a larger button variant.
Changes:
- Widened the button
sizeprop to acceptxl. - Added
xlto Storybook controls for the button component. - Added SCSS rules for
xlsizing, padding, and circle/square width handling.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
src/components/modus-wc-button/modus-wc-button.tsx |
Extends the button prop API to accept xl and passes the new size through class generation. |
src/components/modus-wc-button/modus-wc-button.stories.ts |
Exposes the new xl option in Storybook args and controls. |
src/components/modus-wc-button/modus-wc-button.scss |
Defines the new xl button styles, including general sizing and circle/square width rules. |
|
|
||
| /** The size of the button. */ | ||
| @Prop() size: DaisySize = 'md'; | ||
| @Prop() size: DaisySize | 'xl' = 'md'; |
|
|
||
| /** The size of the button. */ | ||
| @Prop() size: DaisySize = 'md'; | ||
| @Prop() size: DaisySize | 'xl' = 'md'; |
|
|
||
| /** The size of the button. */ | ||
| @Prop() size: DaisySize = 'md'; | ||
| @Prop() size: DaisySize | 'xl' = 'md'; |
…oss/modus-wc-2.0 into 686-add-xl-size-buttons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Summary of Changes
Button: Add xl size
💭 Type of Change
📋 Test Plan
✅ Self Code Review Checklist
PR authors and reviewers, please verify that all of these items have been completed.
🔗 Work Item
Issue #686