Removes unintentional empty projects#14156
Draft
tresat wants to merge 10 commits intotriplea-game:mainfrom
Draft
Removes unintentional empty projects#14156tresat wants to merge 10 commits intotriplea-game:mainfrom
tresat wants to merge 10 commits intotriplea-game:mainfrom
Conversation
- Move a couple things into the convention. - Remove need for another gradle/scripts file.
Moves test map resources to the testFixtures resources directory, allowing for better build organization. Creates a utility class to encapsulate the logic for loading game data from XML files, which simplifies testing. This class handles resource files packaged in jars. Updates tests to use it.
tresat
force-pushed
the
tt/build/remove-phantom-projects
branch
2 times, most recently
from
565154b to
21e5afb
Compare
Contributor
Author
|
Some common objections to this are:
Another common pattern is to add the prefixes, then relocate ALL projects into a |
tresat
force-pushed
the
tt/build/remove-phantom-projects
branch
from
21e5afb to
4db099f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://docs.gradle.org/current/userguide/best_practices_structuring_builds.html#avoid_empty_projects.
There were
:game-app,:http-clientsand:libprojects created that weren't necessary.This also avoids the need to type out
:game-app:game-core, and instead allows the use of just:game-core.Most important, it stops Gradle from assuming these 3 dirs contain Gradle projects, which they don't, improving performance and comprehensibility.