Add support where torchscript model outputs a dictionary of tensors#174
Draft
chdhr-harshal wants to merge 3 commits intotriton-inference-server:mainfrom
Draft
Add support where torchscript model outputs a dictionary of tensors#174chdhr-harshal wants to merge 3 commits intotriton-inference-server:mainfrom
chdhr-harshal wants to merge 3 commits intotriton-inference-server:mainfrom
Conversation
chdhr-harshal
commented
Nov 16, 2025
| if (${TRITON_PYTORCH_NVSHMEM}) | ||
| set(PT_LIBS | ||
| ${PT_LIBS} | ||
| "libtorch_nvshmem.so" |
Author
There was a problem hiding this comment.
Removing this temporarily because I don't have GPU on my personal machine.
chdhr-harshal
commented
Nov 16, 2025
| std::lock_guard<std::mutex> lock(dict_validation_mutex_); | ||
| if (dict_output_validated_.load(std::memory_order_acquire)) { | ||
| return nullptr; | ||
| } |
Author
There was a problem hiding this comment.
Need to use double checking with mutex to make validation threadsafe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This implementation creates mapping per request. Do not continue if output key is not found, raise warning or error.
TODO: Validate output mapping at the model loading time/use warmup and cache.
UPDATE:
TODO: