feat: support tracing option to honor parent sampling#8485
Draft
verdie-g wants to merge 2 commits intotriton-inference-server:mainfrom
Draft
feat: support tracing option to honor parent sampling#8485verdie-g wants to merge 2 commits intotriton-inference-server:mainfrom
verdie-g wants to merge 2 commits intotriton-inference-server:mainfrom
Conversation
Author
|
@GuanLuo could you tell me what you think about this solution? Then I'll work on the testing part. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
OpenTelemetry tracing in Triton only supports one sampling option which is the rate. OpenTelemetry defines some standard samplers. Here I would like to support something close to the popular ParentBased. The sampling decision from the tracing header is used, otherwise a root sampler is used, in our case the rate option.
Checklist
Agreement
<commit_type>: <Title>pre-commit install, pre-commit run --all)Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
Test plan:
Caveats:
Background
I'm trying to have complete traces in my infrastructure but Triton completely ignores the sampling decision of the parent.
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)