Would you consider this big-ass patch? #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ruby-build used to install ruby * ruby built in isolation and symlinked under /usr/local/ruby * Cleaned up logic * upgraded default Ruby version to 1.9.2-p290 * Removed deprecated 'rake/gempackagetask' in Rakefile Tested on Ubuntu Lucid Lynx and CentOS 6.0
Owner
|
My brief read of this suggests that it cleans up a bit of the code. I like that :-) Let me run some tests on this patch over the weekend just to make sure it's good w/ all OS's, then I'll likely pull it in. Thanks! |
Contributor
|
It doesn't seem to make uploading a key optional anymore, not sure if that's a good idea. |
Author
|
@erikh - you make a good point, and I wouldn't have a problem putting that back in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trotter,
Thanks for your work on Spatula. It was exactly what I needed to get started with Chef Solo. I, like most programmers, am opinionated and ended up re-writing a lot of the prepare step. I know it's a big change, and using ruby-build is definitely a big difference, but would you consider this patch? I think it's a good step forward, although I'm still not sure how I like ruby being under /usr/local/ruby instead of /usr/local.
If you are not maintaining spatula, I would love to try my hand at it.
Thanks,
Clinton