NAS-140250 / 26.0.0-BETA.1 / Fix keepalived boot deadlock in configure_addresses_impl (by bmeagherix)#18440
Merged
yocalebo merged 1 commit intorelease/26.0.0-BETA.1from Mar 11, 2026
Conversation
ix-netif.service runs Before=network-pre.target, but keepalived requires After=network-online.target. Starting keepalived from configure_addresses_impl (called via ix-netif.service) caused systemd to queue the start job for ~95s until network-online.target was eventually satisfied after ix-netif.service completed - a structural deadlock. Fix by guarding the keepalived START behind the ix-netif completion sentinel. If keepalived is already running, RELOAD as before. If it is not running and the sentinel exists (i.e. we are in a post-boot interface.sync call), START it. If the sentinel does not exist we are in the early boot call and skip keepalived entirely; it will be started once the network is online. Move NETIF_COMPLETE_SENTINEL from smb_/constants.py to the more appropriate middlewared/utils/interface.py and update importers accordingly. (cherry picked from commit 825ab34)
Contributor
Author
yocalebo
approved these changes
Mar 11, 2026
Contributor
Author
|
This PR has been merged and conversations have been locked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ix-netif.service runs Before=network-pre.target, but keepalived requires After=network-online.target. Starting keepalived from configure_addresses_impl (called via ix-netif.service) caused systemd to queue the start job for ~95s until network-online.target was eventually satisfied after ix-netif.service completed - a structural deadlock.
Fix by guarding the keepalived START behind the ix-netif completion sentinel. If keepalived is already running, RELOAD as before. If it is not running and the sentinel exists (i.e. we are in a post-boot interface.sync call), START it. If the sentinel does not exist we are in the early boot call and skip keepalived entirely; it will be started once the network is online.
Move NETIF_COMPLETE_SENTINEL from smb_/constants.py to the more appropriate middlewared/utils/interface.py and update importers accordingly.
Original PR: #18437