Fix(configure): Correctly persist SPF include and library paths #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous logic for detecting libspf2 temporarily modified the CFLAGS and LDFLAGS shell variables. While this was sufficient for the internal AC_SEARCH_LIBS check to pass, these modifications were not propagated into the final generated Makefiles. This caused build failures in strict environments (e.g., Fedora/EPEL rpmbuild) where CFLAGS is pre-populated with distribution-wide policies. The script's changes were lost, leading to compiler errors like "spf.h: No such file or directory" during the `make` stage. This commit fixes the issue by appending the SPF include and library paths to the standard `CPPFLAGS` and `LDFLAGS` variables, respectively. Signed-off-by: Mikel Olasagasti Uranga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous logic for detecting libspf2 temporarily modified the
CFLAGSandLDFLAGSshell variables. While this was sufficient for the internalAC_SEARCH_LIBScheck to pass, these modifications were not propagated into the final generated Makefiles.This caused build failures in strict environments (e.g., Fedora/EPEL rpmbuild) where
CFLAGSis pre-populated with distribution-wide policies. The script's changes were lost, leading to compiler errors like"spf.h: No such file or directory"during themakestage.This commit fixes the issue by appending the SPF include and library paths to the standard
CPPFLAGSandLDFLAGSvariables, respectively.This commit is required for recent Fedora versions to build.