Fix Linux build and WMI NetworkStream disposal crash #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Build System Fixes - Add LangVersion 12.0 to src/Directory.Build.props to fix C# language version detection for netstandard2.x projects - Add explicit LangVersion 12.0 to Titanis.SourceGen.csproj (netstandard2.0) - Add explicit LangVersion 12.0 to Titanis.Winterop.Security.csproj (netstandard2.1) - Add explicit LangVersion 12.0 to Titanis.Winterop.FileInfo.csproj (netstandard2.1) Previously, netstandard2.0 and netstandard2.1 projects defaulted to C# 7.3 and 8.0, causing build failures with C# 9.0+ and 12.0 features. This enables building on Linux with .NET SDK 8.0. ## Bug Fix - Fix NetworkStream disposal race condition in RpcClientChannel.CancelRequest() Add exception handling to gracefully handle ObjectDisposedException when the NetworkStream is disposed during cleanup before the cancellation callback fires. This prevents crashes after successful WMI command execution. Fixes: Unhandled ObjectDisposedException crash in WMI tool after successful operations 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two critical issues:
Build System Fixes
Projects targeting
netstandard2.0andnetstandard2.1were defaulting to C# 7.3 and 8.0 respectively, despite the globalLangVersion 12.0setting. This caused build failures when using C# 9.0+ features.Changes:
LangVersion 12.0tosrc/Directory.Build.propsfor all src/ projectsLangVersion 12.0to three projects that need it:Titanis.SourceGen.csproj(netstandard2.0)Titanis.Winterop.Security.csproj(netstandard2.1)Titanis.Winterop.FileInfo.csproj(netstandard2.1)Result: Titanis now builds successfully on Linux with .NET SDK 8.0
Bug Fix: NetworkStream Disposal Race Condition
File:
src/net/Titanis.DceRpc/Client/RpcClientChannel.csMethod:
CancelRequest(PendingRequest, CancellationToken)Issue
WMI commands complete successfully but crash immediately after with:
```
Unhandled exception. System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'System.Net.Sockets.NetworkStream'.
```
Root Cause
Race condition in
CancelRequest()method. When a timeout fires or connection closes during cleanup, the cancellation callback attempts to send a CoCancel PDU, but the NetworkStream has already been disposed.Fix
Add try-catch blocks to gracefully handle
ObjectDisposedExceptionand other exceptions during cancellation. Since the request is already being cancelled, failures in sending the cancel PDU are not critical.Testing
Tested on Linux x86-64 with .NET SDK 8.0.415:
Impact