feat: add --csv-header option to encode command#743
Draft
ljluestc wants to merge 2 commits intotsenart:masterfrom
Draft
feat: add --csv-header option to encode command#743ljluestc wants to merge 2 commits intotsenart:masterfrom
ljluestc wants to merge 2 commits intotsenart:masterfrom
Conversation
76d9388 to
70e71bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add --csv-header option to encode command
Background
This PR addresses issue #588 where users requested a way to include headers in CSV output for better readability and easier processing with downstream tools. Currently,
vegeta encodeoutputs raw CSV data without headers, requiring manual workarounds.What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR adds a
--csv-headerflag to thevegeta encodecommand, allowing users to output CSV files with a header row.Implementation Details:
lib/results.go:CSVHeader(lowercase) for consistency.WriteCSVHeader(w io.Writer) errorhelper function.encode.go:--csv-headerflag.WriteCSVHeaderin the encoding loop.lib/results_test.go:TestWriteCSVHeaderto verify the header content matches expectations.Which issue(s) this PR fixes:
Fixes #588
Special notes for your reviewer:
Verification Results
Automated Tests
Ran
go test ./...andmake test(implicit via go test):TestWriteCSVHeaderpassed.Manual Verification
Executed:
Output:
Does this PR introduce a user-facing change?:
Checklist
Background
This PR addresses issue #588 where users requested a way to include headers in CSV output for better readability and easier processing with downstream tools. Currently,
vegeta encodeoutputs raw CSV data without headers, requiring manual workarounds.Checklist