[Proposal]Add basic prettier setup#170
Open
Mindaugas-Jacionis wants to merge 1 commit intotshaddix:masterfrom
Open
[Proposal]Add basic prettier setup#170Mindaugas-Jacionis wants to merge 1 commit intotshaddix:masterfrom
Mindaugas-Jacionis wants to merge 1 commit intotshaddix:masterfrom
Conversation
tshaddix
requested changes
Feb 17, 2019
Owner
tshaddix
left a comment
tshaddix
left a comment
There was a problem hiding this comment.
Thank for doing this! Definitely needed. I think we can remove the references to style files out of the ignore
| *.* | ||
| !*.js | ||
| !*.css | ||
| !*.scss |
Owner
There was a problem hiding this comment.
Do we need to ignore .css and .scss files? I'm not aware of any in this repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to suggest using prettier to enforce code consistency across the project and help out anyone who wants to contribute 🙂