[Proposal] Add basic commit QA tooling#173
Open
Mindaugas-Jacionis wants to merge 2 commits intotshaddix:masterfrom
Open
[Proposal] Add basic commit QA tooling#173Mindaugas-Jacionis wants to merge 2 commits intotshaddix:masterfrom
Mindaugas-Jacionis wants to merge 2 commits intotshaddix:masterfrom
Conversation
tshaddix
reviewed
Feb 17, 2019
| "lint-src": "./node_modules/.bin/eslint src/**/*.js", | ||
| "lint-test": "./node_modules/.bin/eslint test/**/*.js", | ||
| "lint": "npm run lint-src && npm run lint-test", | ||
| "lint": "run-p lint-*", |
Owner
There was a problem hiding this comment.
Can you help me understand a bit more of what is going on here?
There was a problem hiding this comment.
This is using npm-run-all to execute task in parallel. Before they were running sequentially (&&)
It's cross platform and supports globs, like in this case, where it will execute in parallel all scripts that start with lint-.
| "test": "mocha --require babel-core/register", | ||
| "prepare": "npm run prepublish", | ||
| "precommit": "lint-staged", | ||
| "prepush": "yarn qa" |
Owner
There was a problem hiding this comment.
I'm not familiar enough with yarn - is this a yarn only script?
There was a problem hiding this comment.
This sure looks like a typo. I would say this is supposed to be npm run qa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds:
huskyand its hooks to ensure quality of the commits that are pushed. It is not intended to replace CI that runs tests, it is more for contributor to be sure that his/her commit is passing all the tests and follow the linting guidelines for the repo.