Support customized browser api to avoid conflict with global variable#260
Open
arthur791004 wants to merge 2 commits intotshaddix:masterfrom
Open
Support customized browser api to avoid conflict with global variable#260arthur791004 wants to merge 2 commits intotshaddix:masterfrom
arthur791004 wants to merge 2 commits intotshaddix:masterfrom
Conversation
arthur791004
changed the title
tshaddix
requested changes
May 10, 2021
Owner
tshaddix
left a comment
tshaddix
left a comment
There was a problem hiding this comment.
Sorry for the late reply here. This makes sense to me! Thank you for the PR.
Can you also add the new param to the TS file?
https://github.com/tshaddix/webext-redux/blob/master/index.d.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
As a extension development, if we need to use
webext-reduxon certain website which has already define a global variables namedbrowser, it would make it not work because thegetBrowserAPIfunction looks for a global browser api.Therefore, add option named
browserAPIfor development to give the targetbrowserAPIand avoid to looks for a global browser apiChanges
browserAPIand default isnullwhich fallback togetBrowserAPIfunction