Pass complete serialized errors between background and proxy store#262
Open
jlalmes wants to merge 13 commits intotshaddix:masterfrom
jlalmes:master
Open
Pass complete serialized errors between background and proxy store#262jlalmes wants to merge 13 commits intotshaddix:masterfrom jlalmes:master
jlalmes wants to merge 13 commits intotshaddix:masterfrom
jlalmes:master
Conversation
Author
vhmth
requested changes
Nov 15, 2020
Collaborator
vhmth
left a comment
There was a problem hiding this comment.
Thank you for contributing here! 🙏 Just a heads up the reason @tshaddix and I tend to be slow to reply is because our jobs are both extremely demanding. I'm really sorry about the lag here!
This seems very reasonable, and I'm very appreciative of this for the Loom extension itself. Just looked through the code to see where else errors are dispatched, but it seems this is the main throughpoint.
cc @tshaddix any thoughts here?
Before we land, could you check out the tests folder and add an appropriate test there that checks that an error can be dispatched properly and received in an expected manner?
| { | ||
| "name": "webext-redux", | ||
| "version": "2.1.7", | ||
| "name": "webext-redux-w-errors", |
Collaborator
There was a problem hiding this comment.
Could we change back the name here and in package.json?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been facing the issue where
webext-reduxonly allows you toerror.messageback to my content scripts in the case of an error in an aliased action. However my error objects contain other information, for example:This pull request will serialize all errors by default, the full error is then reconciled and rejected to the content-script that called the original dispatch function. You can test this PR with this npm module
webext-redux-w-errors@latest.First-time contributor, open to any feedback! 🙌