Skip to content

add URL parameter authentication support #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add URL parameter authentication support #1464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed57c00
add URL parameter authentication support
claude Aug 18, 2025
3ea13d2
fix URL parameter auth check condition
claude Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/http.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,19 @@ static int check_auth(struct lws *wsi, struct pss_http *pss) {

if(server->credential != NULL) {
char buf[256];
char urlarg_buf[256];

// Check for authorization in headers (default option)
int len = lws_hdr_copy(wsi, buf, sizeof(buf), WSI_TOKEN_HTTP_AUTHORIZATION);
if (len >= 7 && strstr(buf, "Basic ")) {
if (!strcmp(buf + 6, server->credential)) return AUTH_OK;
}

// Check for authorization in URL parameters
if (lws_get_urlarg_by_name(wsi, "authorization", urlarg_buf, sizeof(urlarg_buf)) > 0) {
if (!strcmp(urlarg_buf, server->credential)) return AUTH_OK;
}

return send_unauthorized(wsi, HTTP_STATUS_UNAUTHORIZED, WSI_TOKEN_HTTP_WWW_AUTHENTICATE);
}

Expand Down
11 changes: 10 additions & 1 deletion src/protocol.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,17 @@ static bool check_auth(struct lws *wsi, struct pss_tty *pss) {

if (server->credential != NULL) {
char buf[256];
char urlarg_buf[256];

size_t n = lws_hdr_copy(wsi, buf, sizeof(buf), WSI_TOKEN_HTTP_AUTHORIZATION);
return n >= 7 && strstr(buf, "Basic ") && !strcmp(buf + 6, server->credential);
if (n >= 7 && strstr(buf, "Basic ") && !strcmp(buf + 6, server->credential)) return true;

// Check for authorization in URL parameters
if (lws_get_urlarg_by_name(wsi, "authorization", urlarg_buf, sizeof(urlarg_buf)) > 0) {
if (!strcmp(urlarg_buf, server->credential)) return true;
}

return false;
}

return true;
Expand Down