Skip to content

Improve nob__proc_wait_async API #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve nob__proc_wait_async API #108

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83baea6
Improve API of nob__proc_wait_async by pulling out sleeping into nob_…
TheZouave007 Aug 22, 2025
9c40af9
Fix whitespace problems
TheZouave007 Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 33 additions & 23 deletions nob.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,6 +415,10 @@ NOBDEF int nob_nprocs(void);
// The maximum time span representable is 584 years.
NOBDEF uint64_t nob_nanos_since_unspecified_epoch(void);

// Passing 0 yields the current time slice in the OS scheduler.
// Windows resolution is in ms, not ns, but is rounded up.
NOBDEF void nob_sleep_nanos(uint64_t);

// Same as nob_cmd_run_opt but using cool variadic macro to set the default options.
// See https://x.com/vkrajacic/status/1749816169736073295 for more info on how to use such macros.
#define nob_cmd_run(cmd, ...) nob_cmd_run_opt((cmd), (Nob_Cmd_Opt){__VA_ARGS__})
Expand Down Expand Up @@ -762,10 +766,9 @@ NOBDEF char *nob_win32_error_message(DWORD err);

#ifdef NOB_IMPLEMENTATION

// This is like nob_proc_wait() but waits asynchronously. Depending on the platform ms means different thing.
// On Windows it means timeout. On POSIX it means for how long to sleep after checking if the process exited,
// so to not peg the core too much. Since this API is kinda of weird, the function is private for now.
static int nob__proc_wait_async(Nob_Proc proc, int ms);
// This is like nob_proc_wait() but just checks if the process has completed. If it has, it returns 1. If the
// process is still running, it returns 0. If there was an error, it returns -1.
static int nob__proc_wait_async(Nob_Proc proc);

// Starts the process for the command. Its main purpose is to be the base for nob_cmd_run() and nob_cmd_run_opt().
static Nob_Proc nob__cmd_start_process(Nob_Cmd cmd, Nob_Fd *fdin, Nob_Fd *fdout, Nob_Fd *fderr);
Expand Down Expand Up @@ -1037,13 +1040,12 @@ NOBDEF bool nob_cmd_run_opt(Nob_Cmd *cmd, Nob_Cmd_Opt opt)
if (opt.async && max_procs > 0) {
while (opt.async->count >= max_procs) {
for (size_t i = 0; i < opt.async->count; ++i) {
int ret = nob__proc_wait_async(opt.async->items[i], 1);
int ret = nob__proc_wait_async(opt.async->items[i]);
if (ret < 0) nob_return_defer(false);
if (ret) {
nob_da_remove_unordered(opt.async, i);
break;
}
if (ret) nob_da_remove_unordered(opt.async, i);
}
if (opt.async->count < max_procs) break;
nob_sleep_nanos(1000*1000); // 1ms
}
}

Expand Down Expand Up @@ -1102,6 +1104,23 @@ NOBDEF uint64_t nob_nanos_since_unspecified_epoch(void)
#endif // _WIN32
}

NOBDEF void nob_sleep_nanos(uint64_t ns) {
#ifdef _WIN32
// Not tested on windows, but it should work if it compiles
// round up by one if not an exact number of ms
size_t ms = ns / (1000*1000) + (ns % (1000*1000) > 0);
Sleep(ms);
return;
#else
struct timespec ts = {};
ts.tv_sec = ns / NOB_NANOS_PER_SEC;
ts.tv_nsec = ns % NOB_NANOS_PER_SEC;

nanosleep(&ts, NULL);
return;
#endif
}

NOBDEF Nob_Proc nob_cmd_run_async_redirect(Nob_Cmd cmd, Nob_Cmd_Redirect redirect)
{
return nob__cmd_start_process(cmd, redirect.fdin, redirect.fdout, redirect.fderr);
Expand Down Expand Up @@ -1383,14 +1402,14 @@ NOBDEF bool nob_proc_wait(Nob_Proc proc)
#endif
}

static int nob__proc_wait_async(Nob_Proc proc, int ms)
static int nob__proc_wait_async(Nob_Proc proc)
{
if (proc == NOB_INVALID_PROC) return false;

#ifdef _WIN32
DWORD result = WaitForSingleObject(
proc, // HANDLE hHandle,
ms // DWORD dwMilliseconds
0 // DWORD dwMilliseconds
);

if (result == WAIT_TIMEOUT) {
Expand All @@ -1417,23 +1436,14 @@ static int nob__proc_wait_async(Nob_Proc proc, int ms)

return 1;
#else
long ns = ms*1000*1000;
struct timespec duration = {
.tv_sec = ns/(1000*1000*1000),
.tv_nsec = ns%(1000*1000*1000),
};

int wstatus = 0;
pid_t pid = waitpid(proc, &wstatus, WNOHANG);
if (pid < 0) {
nob_log(NOB_ERROR, "could not wait on command (pid %d): %s", proc, strerror(errno));
return -1;
}

if (pid == 0) {
nanosleep(&duration, NULL);
return 0;
}
if (pid == 0) return 0;

if (WIFEXITED(wstatus)) {
int exit_status = WEXITSTATUS(wstatus);
Expand All @@ -1450,8 +1460,7 @@ static int nob__proc_wait_async(Nob_Proc proc, int ms)
return -1;
}

nanosleep(&duration, NULL);
return 0;
NOB_UNREACHABLE("nob__proc_wait_async did not return before the end of the function!");
#endif
}

Expand Down Expand Up @@ -2304,6 +2313,7 @@ NOBDEF int closedir(DIR *dirp)
#define nprocs nob_nprocs
#define nanos_since_unspecified_epoch nob_nanos_since_unspecified_epoch
#define NANOS_PER_SEC NOB_NANOS_PER_SEC
#define sleep_nanos nob_sleep_nanos
#endif // NOB_STRIP_PREFIX
#endif // NOB_STRIP_PREFIX_GUARD_

Expand Down