Conversation
Co-authored-by: tugraskan <143652012+tugraskan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Move readcio_read statement in proc_bsn.f90
Move Mar 9, 2026
call readcio_read before basin read calls in proc_bsn.f90
…s in proc_bsn.f90 Co-authored-by: tugraskan <143652012+tugraskan@users.noreply.github.com>
Copilot
AI
changed the title
Move
Ensure output files respect configured output path by calling readcio_read first
Mar 9, 2026
call readcio_read before basin read calls in proc_bsn.f90
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving
readcio_readearlier exposed a downstream ordering issue: the three initial output files were opened beforeinit_output_pathran, so they always landed in the working directory regardless of theout_pathconfigured infile.cio.Changes
src/proc_bsn.f90: Promotedcall readcio_readto the very first statement inproc_bsn, ahead of allopen_output_filecalls.All subsequent reads (
basin_read_cc,basin_read_objs,time_read, etc.) also continue to benefit from having theinput_file_modulepaths populated fromfile.ciobefore use.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.