Add build_actions ExecuteParams fixture for tvm_executor#234
Draft
awnion wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
tvm_executortest fixture that buildsExecuteParamsto mirror the acki-nackibuild_actions.rsexecutor path.The fixture covers both regular and
tvm_tracingbranches, explicitly sets allExecuteParamsfields, and documents fields that intentionally keep thebuild_actions.rsdefault behavior.Details
BuildActionsExecuteParamsFixturedebug/trace_callbackregular vs tracing behaviorsignature_id, wasm cache fields,mvconfig, andengine_versionExecuteParamsstruct literal so new fields force fixture updates at compile timeValidation
cargo test -p tvm_executor --libcargo test -p tvm_executor --lib build_actions