Skip to content

Add build_actions ExecuteParams fixture for tvm_executor#234

Draft
awnion wants to merge 1 commit into
mainfrom
feature/node-3408-add-node-like-executeparams-fixture-for-tvm_executor
Draft

Add build_actions ExecuteParams fixture for tvm_executor#234
awnion wants to merge 1 commit into
mainfrom
feature/node-3408-add-node-like-executeparams-fixture-for-tvm_executor

Conversation

@awnion
Copy link
Copy Markdown
Contributor

@awnion awnion commented May 14, 2026

Summary

Adds a tvm_executor test fixture that builds ExecuteParams to mirror the acki-nacki build_actions.rs executor path.

The fixture covers both regular and tvm_tracing branches, explicitly sets all ExecuteParams fields, and documents fields that intentionally keep the build_actions.rs default behavior.

Details

  • Adds BuildActionsExecuteParamsFixture
  • Covers debug / trace_callback regular vs tracing behavior
  • Propagates node-relevant fields including signature_id, wasm cache fields, mvconfig, and engine_version
  • Uses a full ExecuteParams struct literal so new fields force fixture updates at compile time
  • Updates existing executor tests to reuse the fixture instead of hand-building simplified params

Validation

  • cargo test -p tvm_executor --lib
  • cargo test -p tvm_executor --lib build_actions

@awnion awnion self-assigned this May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant