Add newtype to lift classes to monad transformers#272
Open
turion wants to merge 3 commits intotweag:masterfrom
Open
Add newtype to lift classes to monad transformers#272turion wants to merge 3 commits intotweag:masterfrom
turion wants to merge 3 commits intotweag:masterfrom
Conversation
reubenharry
reviewed
May 17, 2023
| random = lift random | ||
| bernoulli = lift . bernoulli | ||
| categorical = lift . categorical | ||
| uniformD = lift . uniformD |
Contributor
There was a problem hiding this comment.
My only note here would be that some of the previous lifting instances appear to have varied slightly. This actually may have been my doing, because I recall that working in a transformed Enumerator didn't lift bernoulli, so that discrete distributions got calculated via random and thus failed with enumerate.
reubenharry
reviewed
May 17, 2023
|
|
||
| instance (MonadTrans t, MonadDistribution m, Monad (t m)) => MonadDistribution (MonadMeasureTrans t m) where | ||
| random = lift random | ||
| uniform = (lift .) . uniform |
Contributor
There was a problem hiding this comment.
Similarly here, there may have been a reason that many of the instances were limited to mostly just lift random. This doesn't change the denotational semantics, but may have efficiency implications, so make sure to benchmark, particularly PMMH and RMSMC.
reubenharry
approved these changes
May 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, it should be possible to derive the
MonadMeasureclass easily for any monad transformer.