-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Twenty standard and workspace custom applications 2/3 #15745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚀 Preview Environment Ready! Your preview environment is available at: http://bore.pub:56854 This environment will automatically shut down when the PR is closed or after 5 hours. |
64e8218 to
227233e
Compare
|
I need to remove v1 code source before this |
|
Blocked by #15823 |
86bb7b7 to
678ad3a
Compare
971a828 to
fcf3c71
Compare
|
I need to refactor migrations command to be handling view universal id and view universal id but also handle the field metadata are some standardId seems ot be invalid by definition but has never been consumed before |
…universalidentifier
…d dynamic relations
|
I don't like what's happening here |
|
It's not only lost but will restart from scratch |
Introduction
In this PR we're migration the syncable entity to have required
applicationIdanduniversalIdenfitier.It has several impacts:
API Metadata
Any operation going through the api metadata nows automatically scope the related entity to the workspace custom application instance. This breaks the existing "hack" implementation of the synchronize application service that calls all the services atomically.
We need to either ignore the tests or remove the cli status check from the blocking status badges for a PR to be merged
New workspace
Already handled in previous #15625, when a workspace is created it gets created a twenty standard and custom workspace instance
Existing workspace
FlatApplication
Introduced the flatApplication and cache. It's a bit hacky right now but will migrate existing
MetadataNameto beSyncableMetadataNamein a following PRV1 Deprecation
Official v1 deprecation as it hasn't been refactored to handle new required appid and universalId
Will remove the code after this PR
Strategy
Sync-metadata governance
The sync metadata has been modified to still allow workspace creation after we apply the required applicationId and universalIdentifier migration
It handles the synchronization of those fields for the following entities: