Update Name of relation fieldMetadata

packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/constants/flat-field-metadata-morph-relation-editable-properties-on-sibling-morph-relation-update.constant.ts

@@ -0,0 +1,26 @@
+import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
+
+export const FLAT_FIELD_METADATA_MORPH_RELATION_EDITABLE_PROPERTIES_ON_SIBLING_MORPH_RELATION_UPDATE_CONSTANT =
+  {
+    custom: [
+      'defaultValue',
+      'description',
+      'icon',
+      'isActive',
+      'isLabelSyncedWithName',
+      'isUnique',
+      'label',
+      'options',
+    ],
+    standard: [
+      'defaultValue',
+      'description',
+      'icon',
+      'isActive',
+      'label',
+      'options',
+    ],
+  } as const satisfies Record<
+    'standard' | 'custom',
+    (keyof FlatFieldMetadata)[]
+  >;

packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/constants/flat-field-metadata-relation-editable-properties-on-sibling-morph-or-relation-update.constant.ts

@@ -0,0 +1,4 @@
+import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
+
+export const FLAT_FIELD_METADATA_RELATION_EDITABLE_PROPERTIES_ON_SIBLING_MORPH_OR_RELATION_UPDATE_CONSTANT =
+  ['isActive'] as const satisfies (keyof FlatFieldMetadata)[];

packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/constants/flat-field-metadata-relation-properties-to-compare.constant.ts

@@ -6,4 +6,6 @@ export const FLAT_FIELD_METADATA_RELATION_PROPERTIES_TO_COMPARE = [
   'isActive',
   'standardOverrides',
   'icon',
+  'name',
+  'settings',
 ] as const satisfies (typeof ALL_FLAT_ENTITY_PROPERTIES_TO_COMPARE_AND_STRINGIFY.fieldMetadata.propertiesToCompare)[number][];

packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/compute-flat-field-metadata-related-flat-field-metadata.util.ts

@@ -33,11 +33,14 @@ export const computeFlatFieldMetadataRelatedFlatFieldMetadata = ({
       FieldMetadataType.MORPH_RELATION,
     )
   ) {
-    return findFlatFieldMetadatasRelatedToMorphRelationOrThrow({
-      flatFieldMetadata,
-      flatFieldMetadataMaps,
-      flatObjectMetadata,
-    });
+    const { morphRelationFlatFieldMetadatas, relationFlatFieldMetadatas } =
+      findFlatFieldMetadatasRelatedToMorphRelationOrThrow({
+        flatFieldMetadata,
+        flatFieldMetadataMaps,
+        flatObjectMetadata,
+      });
+
+    return [...morphRelationFlatFieldMetadatas, ...relationFlatFieldMetadatas];
   }
 
   return [];

packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/compute-flat-field-to-update-and-related-flat-field-to-update.util.ts

@@ -0,0 +1,159 @@
+import { FieldMetadataType, type FromTo } from 'twenty-shared/types';
+
+import { type UpdateFieldInput } from 'src/engine/metadata-modules/field-metadata/dtos/update-field.input';
+import { type AllFlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/all-flat-entity-maps.type';
+import { FLAT_FIELD_METADATA_EDITABLE_PROPERTIES } from 'src/engine/metadata-modules/flat-field-metadata/constants/flat-field-metadata-editable-properties.constant';
+import { FLAT_FIELD_METADATA_MORPH_RELATION_EDITABLE_PROPERTIES_ON_SIBLING_MORPH_RELATION_UPDATE_CONSTANT } from 'src/engine/metadata-modules/flat-field-metadata/constants/flat-field-metadata-morph-relation-editable-properties-on-sibling-morph-relation-update.constant';
+import { FLAT_FIELD_METADATA_RELATION_EDITABLE_PROPERTIES_ON_SIBLING_MORPH_OR_RELATION_UPDATE_CONSTANT } from 'src/engine/metadata-modules/flat-field-metadata/constants/flat-field-metadata-relation-editable-properties-on-sibling-morph-or-relation-update.constant';
+import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
+import { findFlatFieldMetadatasRelatedToMorphRelationOrThrow } from 'src/engine/metadata-modules/flat-field-metadata/utils/find-flat-field-metadatas-related-to-morph-relation-or-throw.util';
+import { findRelationFlatFieldMetadataTargetFlatFieldMetadataOrThrow } from 'src/engine/metadata-modules/flat-field-metadata/utils/find-relation-flat-field-metadatas-target-flat-field-metadata-or-throw.util';
+import { isFlatFieldMetadataOfType } from 'src/engine/metadata-modules/flat-field-metadata/utils/is-flat-field-metadata-of-type.util';
+import { sanitizeRawUpdateFieldInput } from 'src/engine/metadata-modules/flat-field-metadata/utils/sanitize-raw-update-field-input';
+import { type FlatObjectMetadata } from 'src/engine/metadata-modules/flat-object-metadata/types/flat-object-metadata.type';
+import { isStandardMetadata } from 'src/engine/metadata-modules/utils/is-standard-metadata.util';
+import { mergeUpdateInExistingRecord } from 'src/utils/merge-update-in-existing-record.util';
+
+type ComputeFlatFieldToUpdateAndRelatedFlatFieldToUpdateReturnType = {
+  flatFieldMetadataFromTo: FromTo<FlatFieldMetadata, 'flatFieldMetadata'>;
+  relatedFlatFieldMetadatasFromTo: FromTo<
+    FlatFieldMetadata,
+    'flatFieldMetadata'
+  >[];
+};
+
+type ComputeFlatFieldToUpdateAndRelatedFlatFieldToUpdateArgs = {
+  rawUpdateFieldInput: UpdateFieldInput;
+  fromFlatFieldMetadata: FlatFieldMetadata;
+  flatObjectMetadata: FlatObjectMetadata;
+} & Pick<AllFlatEntityMaps, 'flatFieldMetadataMaps'>;
+// Note: Standard override is way too complex we should land a smoother implemenentation once we standardize
+// them across every flat entities
+export const computeFlatFieldToUpdateAndRelatedFlatFieldToUpdate = ({
+  fromFlatFieldMetadata,
+  rawUpdateFieldInput,
+  flatFieldMetadataMaps,
+  flatObjectMetadata,
+}: ComputeFlatFieldToUpdateAndRelatedFlatFieldToUpdateArgs): ComputeFlatFieldToUpdateAndRelatedFlatFieldToUpdateReturnType => {
+  const { standardOverrides, updatedEditableFieldProperties } =
+    sanitizeRawUpdateFieldInput({
+      existingFlatFieldMetadata: fromFlatFieldMetadata,
+      rawUpdateFieldInput,
+    });
+
+  const isStandardField = isStandardMetadata(fromFlatFieldMetadata);
+
+  const toFlatFieldMetadata = {
+    ...mergeUpdateInExistingRecord({
+      existing: fromFlatFieldMetadata,
+      properties:
+        FLAT_FIELD_METADATA_EDITABLE_PROPERTIES[
+          isStandardField ? 'standard' : 'custom'
+        ],
+      update: updatedEditableFieldProperties,
+    }),
+    standardOverrides,
+  };
+
+  if (
+    isFlatFieldMetadataOfType(fromFlatFieldMetadata, FieldMetadataType.RELATION)
+  ) {
+    const relatedFlatFieldMetadataFrom =
+      findRelationFlatFieldMetadataTargetFlatFieldMetadataOrThrow({
+        flatFieldMetadata: fromFlatFieldMetadata,
+        flatFieldMetadataMaps,
+      });
+
+    const relatedFlatFieldMetadataTo = mergeUpdateInExistingRecord({
+      existing: relatedFlatFieldMetadataFrom as FlatFieldMetadata,
+      properties:
+        FLAT_FIELD_METADATA_RELATION_EDITABLE_PROPERTIES_ON_SIBLING_MORPH_OR_RELATION_UPDATE_CONSTANT,
+      update: updatedEditableFieldProperties,
+    });
+
+    return {
+      flatFieldMetadataFromTo: {
+        fromFlatFieldMetadata,
+        toFlatFieldMetadata,
+      },
+      relatedFlatFieldMetadatasFromTo: [
+        {
+          fromFlatFieldMetadata: relatedFlatFieldMetadataFrom,
+          toFlatFieldMetadata: relatedFlatFieldMetadataTo,
+        },
+      ],
+    };
+  }
+
+  if (
+    isFlatFieldMetadataOfType(
+      fromFlatFieldMetadata,
+      FieldMetadataType.MORPH_RELATION,
+    )
+  ) {
+    const { morphRelationFlatFieldMetadatas, relationFlatFieldMetadatas } =
+      findFlatFieldMetadatasRelatedToMorphRelationOrThrow({
+        flatFieldMetadata: fromFlatFieldMetadata,
+        flatFieldMetadataMaps,
+        flatObjectMetadata,
+      });
+
+    const relatedMorphRelationFlatFieldMetdataTo =
+      morphRelationFlatFieldMetadatas.map<
+        FromTo<FlatFieldMetadata, 'flatFieldMetadata'>
+      >((relatedFlatFieldMetadataFrom) => {
+        const relatedMorphPropertiesToUpdateTo =
+          FLAT_FIELD_METADATA_MORPH_RELATION_EDITABLE_PROPERTIES_ON_SIBLING_MORPH_RELATION_UPDATE_CONSTANT[
+            isStandardField ? 'standard' : 'custom'
+          ];
+        const relatedFlatFieldMetadataTo = {
+          ...mergeUpdateInExistingRecord({
+            existing: relatedFlatFieldMetadataFrom as FlatFieldMetadata,
+            properties: relatedMorphPropertiesToUpdateTo,
+            update: updatedEditableFieldProperties,
+          }),
+          standardOverrides,
+        };
+
+        return {
+          fromFlatFieldMetadata: relatedFlatFieldMetadataFrom,
+          toFlatFieldMetadata: relatedFlatFieldMetadataTo,
+        };
+      });
+
+    const relatedRelationFlatFieldMetadataTo = relationFlatFieldMetadatas.map<
+      FromTo<FlatFieldMetadata, 'flatFieldMetadata'>
+    >((relatedFlatFieldMetadataFrom) => {
+      const relatedFlatFieldMetadataTo = mergeUpdateInExistingRecord({
+        existing: relatedFlatFieldMetadataFrom as FlatFieldMetadata,
+        properties:
+          FLAT_FIELD_METADATA_RELATION_EDITABLE_PROPERTIES_ON_SIBLING_MORPH_OR_RELATION_UPDATE_CONSTANT,
+        update: updatedEditableFieldProperties,
+      });
+
+      return {
+        fromFlatFieldMetadata: relatedFlatFieldMetadataFrom,
+        toFlatFieldMetadata: relatedFlatFieldMetadataTo,
+      };
+    });
+
+    return {
+      flatFieldMetadataFromTo: {
+        fromFlatFieldMetadata,
+        toFlatFieldMetadata,
+      },
+      relatedFlatFieldMetadatasFromTo: [
+        ...relatedMorphRelationFlatFieldMetdataTo,
+        ...relatedRelationFlatFieldMetadataTo,
+      ],
+    };
+  }
+
+  return {
+    flatFieldMetadataFromTo: {
+      fromFlatFieldMetadata,
+      toFlatFieldMetadata,
+    },
+    relatedFlatFieldMetadatasFromTo: [],
+  };
+};

packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/find-field-related-index.util.ts

@@ -0,0 +1,26 @@
+import { type FlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-maps.type';
+import { findManyFlatEntityByIdInFlatEntityMapsOrThrow } from 'src/engine/metadata-modules/flat-entity/utils/find-many-flat-entity-by-id-in-flat-entity-maps-or-throw.util';
+import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
+import { type FlatIndexMetadata } from 'src/engine/metadata-modules/flat-index-metadata/types/flat-index-metadata.type';
+import { type FlatObjectMetadata } from 'src/engine/metadata-modules/flat-object-metadata/types/flat-object-metadata.type';
+
+export const findFieldRelatedIndexes = ({
+  flatFieldMetadata,
+  flatObjectMetadata,
+  flatIndexMaps,
+}: {
+  flatFieldMetadata: FlatFieldMetadata;
+  flatObjectMetadata: FlatObjectMetadata;
+  flatIndexMaps: FlatEntityMaps<FlatIndexMetadata>;
+}): FlatIndexMetadata[] => {
+  const objectIndexes = findManyFlatEntityByIdInFlatEntityMapsOrThrow({
+    flatEntityMaps: flatIndexMaps,
+    flatEntityIds: flatObjectMetadata.indexMetadataIds,
+  });
+
+  return objectIndexes.filter((index) =>
+    index.flatIndexFieldMetadatas.some(
+      (indexField) => indexField.fieldMetadataId === flatFieldMetadata.id,
+    ),
+  );
+};

packages/twenty-server/src/engine/metadata-modules/flat-field-metadata/utils/find-flat-field-metadatas-related-to-morph-relation-or-throw.util.ts

@@ -1,6 +1,5 @@
 import { type FieldMetadataType } from 'twenty-shared/types';
 
-import { type MorphOrRelationFieldMetadataType } from 'src/engine/metadata-modules/field-metadata/types/morph-or-relation-field-metadata-type.type';
 import { type FlatEntityMaps } from 'src/engine/metadata-modules/flat-entity/types/flat-entity-maps.type';
 import { type FlatFieldMetadata } from 'src/engine/metadata-modules/flat-field-metadata/types/flat-field-metadata.type';
 import { findAllOthersMorphRelationFlatFieldMetadatasOrThrow } from 'src/engine/metadata-modules/flat-field-metadata/utils/find-all-others-morph-relation-flat-field-metadatas-or-throw.util';
@@ -12,32 +11,35 @@ export type FindFlatFieldMetadatasRelatedToMorphRelationOrThrowArgs = {
   flatFieldMetadata: FlatFieldMetadata<FieldMetadataType.MORPH_RELATION>;
   flatObjectMetadata: FlatObjectMetadata;
 };
+
+type FindFlatFieldMetadatasRelatedToMorphRelationOrThrowReturnType = {
+  morphRelationFlatFieldMetadatas: FlatFieldMetadata<FieldMetadataType.MORPH_RELATION>[];
+  relationFlatFieldMetadatas: FlatFieldMetadata<FieldMetadataType.RELATION>[];
+};
 export const findFlatFieldMetadatasRelatedToMorphRelationOrThrow = ({
   flatFieldMetadataMaps,
   flatFieldMetadata: morphRelationFlatFieldMetadata,
   flatObjectMetadata,
-}: FindFlatFieldMetadatasRelatedToMorphRelationOrThrowArgs): FlatFieldMetadata<MorphOrRelationFieldMetadataType>[] => {
-  const allMorphFlatFieldMetadatas =
+}: FindFlatFieldMetadatasRelatedToMorphRelationOrThrowArgs): FindFlatFieldMetadatasRelatedToMorphRelationOrThrowReturnType => {
+  const morphRelationFlatFieldMetadatas =
     findAllOthersMorphRelationFlatFieldMetadatasOrThrow({
       flatFieldMetadata: morphRelationFlatFieldMetadata,
       flatFieldMetadataMaps,
       flatObjectMetadata,
     });
 
-  return [
+  const relationFlatFieldMetadatas = [
     morphRelationFlatFieldMetadata,
-    ...allMorphFlatFieldMetadatas,
-  ].flatMap((flatFieldMetadata) => {
-    const relationTargetFlatFieldMetadata =
-      findRelationFlatFieldMetadataTargetFlatFieldMetadataOrThrow({
-        flatFieldMetadata,
-        flatFieldMetadataMaps,
-      });
-
-    if (flatFieldMetadata.id === morphRelationFlatFieldMetadata.id) {
-      return [relationTargetFlatFieldMetadata];
-    }
+    ...morphRelationFlatFieldMetadatas,
+  ].map((flatFieldMetadata) =>
+    findRelationFlatFieldMetadataTargetFlatFieldMetadataOrThrow({
+      flatFieldMetadata,
+      flatFieldMetadataMaps,
+    }),
+  ) as FlatFieldMetadata<FieldMetadataType.RELATION>[];
 
-    return [flatFieldMetadata, relationTargetFlatFieldMetadata];
-  });
+  return {
+    morphRelationFlatFieldMetadatas,
+    relationFlatFieldMetadatas,
+  };
 };