Skip to content

Conversation

@mabdullahabaid
Copy link
Member

There was an extra definition of @nx/js inside twenty-server, which was not recognized during upgrade by the CLI. This caused two versions of @nx/js in the repo - 22.0.3 from root and 21.3.11 from the twenty-server package.

Removed the one inside twenty-server to maintain a single source of truth.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 18, 2025

Greptile Summary

  • Removed duplicate @nx/js 21.3.11 from packages/twenty-server/package.json to resolve version conflict with root package
  • Consolidated to single @nx/js 22.0.3 version from root, eliminating inconsistency

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Simple dependency cleanup removing duplicate package definition that was causing version conflicts. The root package already provides @nx/js 22.0.3, and yarn properly resolved dependencies after removal.
  • No files require special attention

Sequence Diagram

sequenceDiagram
    participant Dev as "Developer"
    participant CLI as "Nx CLI"
    participant Root as "Root package.json"
    participant Server as "twenty-server package.json"
    
    Dev->>CLI: "Run nx upgrade"
    CLI->>Root: "Update @nx/js to 22.0.3"
    Note over CLI,Server: "CLI missed duplicate in twenty-server"
    Dev->>Server: "Remove @nx/js 21.3.11"
    Dev->>CLI: "Run yarn install"
    CLI->>Root: "Resolve dependencies from root"
    Root-->>Server: "Provide @nx/js 22.0.3"
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

@charlesBochet charlesBochet merged commit 9c61b62 into main Nov 18, 2025
63 of 65 checks passed
@charlesBochet charlesBochet deleted the nx-fix branch November 18, 2025 16:41
@github-actions
Copy link
Contributor

🚀 Preview Environment Ready!

Your preview environment is available at: http://bore.pub:53353

This environment will automatically shut down when the PR is closed or after 5 hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants