fix: infer phone country code from E.164 numbers in workflow Create Record#19063
Closed
jnMetaCode wants to merge 1 commit intotwentyhq:mainfrom
Closed
fix: infer phone country code from E.164 numbers in workflow Create Record#19063jnMetaCode wants to merge 1 commit intotwentyhq:mainfrom
jnMetaCode wants to merge 1 commit intotwentyhq:mainfrom
Conversation
…workflows When a workflow maps a variable containing an E.164 phone number (e.g. "+919999999999") to a phone field, the calling code and country code sub-fields are sent as empty strings. The nullish coalescing operator (??) treated these empty strings as valid values, preventing the backend from inferring the calling code and country from the E.164 number itself. Replace ?? with isNonEmptyString() checks so that empty strings are treated as "not provided", allowing libphonenumber-js to correctly infer calling code and country code from the phone number. Fixes twentyhq#17182
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Contributor
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Member
|
@jnMetaCode Please stop opening AI generated PR on this repository. You are not helping us and harming the community. This will be the only warning before ban: one more and that's it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
+91) and country code when a phone field is populated with an E.164 number via variable mapping (e.g. from a webhook payload)validateAndInferMetadataFromPrimaryPhoneNumberused the nullish coalescing operator (??) to decide whether to infer calling/country codes from the phone number. Since the workflow frontend sends empty strings ('') for unset calling code and country code sub-fields,??treated them as valid values and skipped inference.??withisNonEmptyString()checks so that empty strings are treated as "not provided", allowinglibphonenumber-jsto correctly parse and infer both calling code and country code from E.164 formatted phone numbers.transformPhonesValuecovering E.164 inference, explicit values, and edge cases.Test plan
+919999999999) to a Phone field correctly stores calling code (+91) and country code (IN)transformPhonesValueunit testsFixes #17182