Skip to content

chore: fix python generation issue for nested object#770

Merged
kridai merged 4 commits intomainfrom
python-nested-object-fix
Mar 24, 2026
Merged

chore: fix python generation issue for nested object#770
kridai merged 4 commits intomainfrom
python-nested-object-fix

Conversation

@kridai
Copy link
Contributor

@kridai kridai commented Feb 13, 2026

Fixes

Added two fixes

  • Empty to_dict generation for nested object. This was happening due to json-name not getting propagated to nested objects
  • reserved Keyword for nested property fix. Should use name instead of baseName, sInce name has the updated value for reserved keyword like _from for from.

Code generated of conversation v2 here twilio/twilio-python#909

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • Run make test-docker
  • Verify affected language according to the code change:
    • Generate twilio-java from our OpenAPI specification using the scripts/build_twilio_library.py using python scripts/build_twilio_library.py path/to/twilio-oai/spec/yaml path/to/twilio-java -l java and inspect the diff
    • Run make test in twilio-java
    • Create a pull request in twilio-java
    • Provide a link below to the pull request, this ensures that the generated code has been verified
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.

@kridai kridai added this pull request to the merge queue Mar 24, 2026
@kridai kridai removed this pull request from the merge queue due to a manual request Mar 24, 2026
@kridai kridai merged commit 81b0255 into main Mar 24, 2026
17 checks passed
@kridai kridai deleted the python-nested-object-fix branch March 24, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants